Skip to content

fix(io): platform-detection helpers + tiebreak (shared base)#64

Open
EliHei2 wants to merge 1 commit into
mainfrom
feat/io-platform-detection
Open

fix(io): platform-detection helpers + tiebreak (shared base)#64
EliHei2 wants to merge 1 commit into
mainfrom
feat/io-platform-detection

Conversation

@EliHei2

@EliHei2 EliHei2 commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Add the small shared building blocks used by the CosMX/MERSCOPE readers: column/schema resolution helpers (_lazyframe_column_names, _first_existing), boundary-index + empty-boundaries helpers, assignment-id cleaning, and a directory/schema-based _platform_tiebreak wired into _infer_platform so an ambiguous directory resolves instead of erroring. No behavior change for unambiguous Xenium dirs. Base for bugfix/read-cosmx and bugfix/read-merscope.

Add the small shared building blocks used by the CosMX/MERSCOPE readers:
column/schema resolution helpers (_lazyframe_column_names, _first_existing),
boundary-index + empty-boundaries helpers, assignment-id cleaning, and a
directory/schema-based _platform_tiebreak wired into _infer_platform so an
ambiguous directory resolves instead of erroring. No behavior change for
unambiguous Xenium dirs. Base for bugfix/read-cosmx and bugfix/read-merscope.
@EliHei2 EliHei2 requested a review from Tobiaspk June 1, 2026 13:14
@Tobiaspk

Tobiaspk commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Notes on all the data-reader PRs (#60, #63, #64): could we pack these into a new branch for now, so people can use them when needed already?

I think we should re-evaluate how to support IO. spatialdata uses spatialdata-io for all read-write. I haven't looked into it closely yet, but ideally there's a way to outsource or share some maintenance burden.

Open for discussion, what are your thoughts on the following:
A) Keep in segger main: requires proper test cases and documentation.
B) Separate dep we maintain: similar in spirit to spatialdata-io; cleanly separates the tool from IO.
C) Use (or extend) spatialdata-io directly: this is probably the cleanest path; if readers are missing we can share maintenance with that community rather then host our own version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants